From new core setting : use shareapi_only_share_with_group_members_ex… #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
force-pushed
the
feature/nextcloud-37677/exclude-some-groups-from-sharing-with-users
branch
from
c1ef06b to
bad487e
Compare
|
Hey @smarinier 👋 I tested with @dorianne-arawa and it's okay for her. Can you tell me if it's okay for you too ? |
|
This PR will be for release 3.1.0 in addition to main |
zak39
force-pushed
the
feature/nextcloud-37677/exclude-some-groups-from-sharing-with-users
branch
3 times, most recently
from
6bd4957 to
346dda7
Compare
6 tasks
Limit the search to members of the same group except for specific groups. I splited the code in 2 classes : - GroupMembersOnlyChecker : To check if the checkbox for the "Allow apps to use the Share API" and check if groups are listed from the multiselect. - ShareMembersOnlyFilter : to get the members only the same group or excepted a few groups from the multiselect. Return users with common groups. Except users belonging to groups listed in the drop-down list (`Settings > Share > Restrict users to only share with users in their groups > Ingore the following groups when cheking group membership`). Signed-off-by: Baptiste Fotia <[email protected]>
zak39
force-pushed
the
feature/nextcloud-37677/exclude-some-groups-from-sharing-with-users
branch
from
b122b8e to
cab2069
Compare
zak39
deleted the
feature/nextcloud-37677/exclude-some-groups-from-sharing-with-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…clude_group_list (nextcloud issue 37677)